[JENKINS-55138] Don't close kubernetes client upon cache removal #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
force-pushed
the
JENKINS-55138
branch
from
932bcb0
to
4430f29
Compare
Added a SaveableListener to invalidate cache when Jenkins object is being saved. Instead of blindly closing the KubernetesClient when evicted from the cache, put it in a list to monitor. Then every minute, PurgeExpiredKubernetesClients will check if there are still http connections and close it when it becomes unused.
Vlatombe
force-pushed
the
JENKINS-55138
branch
from
4430f29
to
486218a
Compare
Vlatombe
changed the title
|
This is becoming overly complicated I wonder if there is a better way without doing caching |
carlossg
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a SaveableListener to invalidate cache when Jenkins object is
being saved.
Instead of blindly closing the KubernetesClient when evicted from the
cache, put it in a list to monitor. Then every minute,
PurgeExpiredKubernetesClientswill check if there are still http connectionsand close it when it becomes unused.